search

cooperka / react-native-snackbar

:candy: Material Design "Snackbar" component for Android and iOS.
Other
815 stars 150 forks source link

Reduce size of npm package #153

Closed sonicdoe closed 4 years ago

sonicdoe commented 4 years ago

Reduces the size of the npm package by excluding src/__tests__ and various Xcode and Android/IntelliJ files. Publishing a new version with these changes would reduce the size from about 20 MB and over 4,000 files to around 200 KB and 40 files.

Resolves #143.

cooperka commented 4 years ago

Thank you @sonicdoe. I much appreciate your self-documenting commits and clear PR description, it saves me a lot of time trying to validate things. Cheers ❤️

sonicdoe commented 4 years ago

Thank you, it’s nice to hear that they were helpful 🙂

Could you take a look at the v2.2.1 release? npm pack react-native-snackbar@2.2.1 still reports 4,451 files. How many files is npm pack --dry-run reporting when you run it locally? Which version of npm are you using?

cooperka commented 4 years ago

Hmm, npm pack --dry-run reports 27 files on v6.10.2, but I published using Yarn v1.22.4. Apparently Yarn has different inheritance logic (reported in https://github.com/yarnpkg/yarn/issues/685) so the current config doesn't work for Yarn. What a pain 💩

I'll release again with npm instead, but I can't guarantee I'll remember to do that every time... I'll re-open #143 as a reminder to myself (or anyone else who wants to take a swing at a fix that works for both yarn and npm)