search

cooperka / react-native-snackbar

:candy: Material Design "Snackbar" component for Android and iOS.
Other
823 stars 152 forks source link

Fix Android X compatibility issue and DRY code #177

Closed rkbhochalya closed 3 years ago

rkbhochalya commented 3 years ago

This PR:

troZee commented 3 years ago

This PR https://github.com/cooperka/react-native-snackbar/pull/176/files fixes android x issue

rkbhochalya commented 3 years ago

@troZee yes but that one should be closed in favor of this one as it also removes unnecessary use of findViewById.

troZee commented 3 years ago

@troZee yes but that one should be closed in favor of this one as it also removes unnecessary use of findViewById.

Ohh I see. My bad

gioragutt commented 3 years ago

Hi guys, is this going to be merged?

cooperka commented 3 years ago

Thanks for the simple fix @rkbhochalya (and @RublevD for the original one)!

gioragutt commented 3 years ago

Thanks for the simple fix @rkbhochalya (and @RublevD for the original one)!

Thanks for the reactivity man 👌🏻 do you know when a fixed version will be released?

cooperka commented 3 years ago

Yes it's https://github.com/cooperka/react-native-snackbar/releases/tag/v2.3.2