search

cooperka / react-native-snackbar

:candy: Material Design "Snackbar" component for Android and iOS.
Other
823 stars 152 forks source link

Update to Android API 27 #72 #73

Closed ripern closed 6 years ago

ripern commented 6 years ago

PR for issue #72

cooperka commented 6 years ago

Hi @ripern, thanks for the contribution. Is there any specific reason for this upgrade? In general, I don't like updating dependencies like this because it's hard to know what it might break on other people's apps. If there's a clear benefit, though, I'm willing to test it out.

cooperka commented 6 years ago

@masteralb, I see you've reacted a few times to this PR. Can you explain why you'd like this merged? It's not clear to me what the benefit might be. If anyone has a good reason, I'm happy to re-open and merge.

masteralb commented 6 years ago

@cooperka, i'm using this on my project. With current configuration i can't compile. #72 has fixed the compile errors. Thank you.

cooperka commented 6 years ago

Hmm, that's strange. Any chance you can post the original error you were seeing?