search

cooperlyt / keycloak-phone-provider

A Keycloak provider for phone and SMS
MIT License
252 stars 147 forks source link

Missing OTP over SMS in keycloak-22.x.x branch #81

Open mertcanakdeniz opened 9 months ago

mertcanakdeniz commented 9 months ago

Hey cooperlyt. There is an issue related with OTP over SMS option. So in So when i looked up your commits on this branch, i saw remove related line in service. Here is missing part :
keycloak-phone-provider/src/main/resources/META-INF/services/org.keycloak.authentication.AuthenticatorFactory

so this is caused by can not choosing OTP over SMS option for keycloak 22 versions.

So i add on your code related line again and i check it is came.

Here is the commit that I fixed in push request .. https://github.com/cooperlyt/keycloak-phone-provider/commit/bb01e4aa6f784db6721eaab5ff6cf82d39a4dea4#diff-c25697a567ca6bd16fd8582c7c93be59f35b7fc8e5fcbfb66ad32d651836ecc2

Thank you for all developments

Regards.

mertcanakdeniz commented 9 months ago

Here is the commit that I fixed in push request .. https://github.com/cooperlyt/keycloak-phone-provider/commit/bb01e4aa6f784db6721eaab5ff6cf82d39a4dea4#diff-c25697a567ca6bd16fd8582c7c93be59f35b7fc8e5fcbfb66ad32d651836ecc2