search

coopermaruyama / tableau-react

Tableau React component integrated with Tableau JS API.
MIT License
77 stars 60 forks source link

Updated tableau api dependency #14

Closed nmario closed 4 years ago

coopermaruyama commented 5 years ago

Hi, what’s the difference on your fork?

voglster commented 5 years ago

When I looked it looks like its just a different repo pointing to tableau 2.2.2 packaged up as npm installable.

ivanmcgregor commented 4 years ago

I can confirm what @voglster was saying. However, when I tried it locally it didn't work. It might be due to the fact that this is exposed differently. It's just using the basic tableau, the currently used is already modified. It does work when you change the use of Tableau instead of being used as an import by webpack to window.tableau.

coopermaruyama commented 4 years ago

I would prefer if the tableau JS was directly distributed with this repo. This package currently (and also if this pull request is accepted) would contain a security vulnerability since the owner of the dependent repo can add any code they want.

The actual tableau script is available here: https://public.tableau.com/javascripts/api/tableau-2.3.0.js

Also, looking at the proposed repo, it looks like it's not wrapping the tableau API correctly, so it won't work anyways. If you look at the one being used currently, you can see at the end that the author added module.exports = .... in order to wrap it.

I've begun work on a branch that bundles this in directly but due to the vast differences in the scripts, all the tests are failing so I will need to rewrite them.

Closing this, feel free to re-open if needed