search

coopermaruyama / tableau-react

Tableau React component integrated with Tableau JS API.
MIT License
77 stars 60 forks source link

Check if the sheet is loaded before applying filters #30

Closed victor-carv closed 2 years ago

victor-carv commented 3 years ago

Fix for https://github.com/coopermaruyama/tableau-react/issues/29

coopermaruyama commented 3 years ago

thanks for this will check it out soon. do you have some setting in your editor that is auto formatting? the diff is a bit hard to parse because there are so many changes that just reformat code without changing behavior. also is there a reason tableau is now being loaded in global scope?

victor-carv commented 3 years ago

thanks for this will check it out soon. do you have some setting in your editor that is auto formatting? the diff is a bit hard to parse because there are so many changes that just reformat code without changing behavior. also is there a reason tableau is now being loaded in global scope?

Hi @coopermaruyama! I was actually doing some testing and I forgot that my master was linked to this PR, my bad. I just updated it.

coopermaruyama commented 2 years ago

i have manually applied your change in 2.1.0 to avoid solving conflicts. thanks!