coopermaruyama / tableau-react

Tableau React component integrated with Tableau JS API.
MIT License
77 stars 60 forks source link

Adds safety to the changeParameterValueAsync on workbook #8

Closed cammanderson closed 5 years ago

cammanderson commented 6 years ago

In the case that parameters change before the workbook has loaded, it can throw an exception and break the application.

This pull request adds safety to the call to changeParameterValueAsync().

The developer will still need to handle their possible race condition with changing parameters before the workbook loads, but this will ensure that the component does not throw an exception.

coopermaruyama commented 5 years ago

Fixed conflicts and merged. thank you