Fix refreshIdle and min size check in _removeIdle

coopernurse / node-pool

Generic resource pooling for node.js

2.38k stars 259 forks source link

Fix refreshIdle and min size check in _removeIdle #121

Closed mikemorris closed 8 years ago

mikemorris commented 8 years ago

Prior to this patch, a true value for refreshIdle (the default) would cause all objects in a pool to be eligible for destruction in _removeIdle, regardless of the min pool size. Likewise, a false value for refreshIdle (intended to prevent idle object culling) would be ignored as long as the min size check passed.

sandfox commented 8 years ago

Cool, thanks for finding and fixing this. shipped in v2.4.1