search

coopernurse / node-pool

Generic resource pooling for node.js
2.38k stars 259 forks source link

Add lint checks to the Travis tests #134

Closed kevinburkeshyp closed 8 years ago

kevinburkeshyp commented 8 years ago

This will fail new builds/PR's if they fail to conform to the style guide. Fixes the one line that was not conforming to the style guide.

If you npm run a command, npm prints a big long spiel to the command line about how it's not responsible for the failure (example: https://travis-ci.org/Shyp/node-pool/jobs/111683457#L566). We may want to just run the commands directly (via ./node_modules/.bin/eslint ...) instead of calling npm run.

sandfox commented 8 years ago

yeah, unfortunately the eslint stuff only works on node 0.10 and above (hence it not being part of the normal install/test commands). If you can come up some wrappers that only run the install+lint stuff for the correct versions I'm happy to merge this into master.

Once we bump the major version the linting will become non-optional as we'll probably drop support for anything less than node v4

kevinburkeshyp commented 8 years ago

Alright, added a conditional that checks for v0.10 or higher.

kevinburkeshyp commented 8 years ago

Ping :)

sandfox commented 8 years ago

finally merged it! thanks :-)