search

coopernurse / node-pool

Generic resource pooling for node.js
2.38k stars 259 forks source link

Process hangs with refreshIdle: false #148

Closed olalonde closed 7 years ago

olalonde commented 8 years ago

refreshIdle: false should prevent the remove timeout from being called, but it doesn't: https://github.com/coopernurse/node-pool/blob/master/lib/generic-pool.js#L243

sandfox commented 7 years ago

The documentation around refreshIdle (and it's name) is a little unclear. What it really means is "should I timeout resources which are part of the min pool size" It doesn't turn off/on the general timeout behaviour - that is controlled by reapInterval and idleTimeoutMillis

Feel free to re-open this if you still something is broken.