Closed artursgirons closed 5 years ago
Do you have an example or demo that I can use to reproduce this error?
I think this happens in Pool._testOnBorrow
So it seems _dispense()
is creating a promise but not returning it???
@eseliger where?
I was thinking of this line: https://github.com/coopernurse/node-pool/blob/master/lib/Pool.js#L167 but its just a guess
Ok, I'll see what I can work out about whats happening here
@eseliger It has its handler in line 170. But we should add a catch.
Ah, I think it was most likely my removal of the return null
in https://github.com/coopernurse/node-pool/commit/f5a93df86e58b2fd50e7f8c12c1c05c0a14b5572#diff-1b589a05fcf1509343500faf9cd70bdaL314
I did wonder why it was there to start with... now we know!
fixed and published in v3.6.1
This started to show up when upgraded from 3.4.0 to 3.6.0. Using
sequelize
and this happens when callingconnection.authenticate()
Warning: a promise was created in a handler at /workspace/node_modules/generic-pool/lib/Pool.js:319:14 but was not returned from it, see http://goo.gl/rRqMUw at Function.Promise.cast (/workspace/node_modules/bluebird/js/release/promise.js:196:13)