search

cooperspencer / gickup

https://cooperspencer.github.io/gickup-documentation/
Apache License 2.0
988 stars 38 forks source link

Adds Prometheus metrics when in scheduled mode #62

Closed colindean closed 2 years ago

colindean commented 2 years ago

As submitted, this also pulls in InfluxDB2 libraries and sets up the stuff, but I don't have it doing anything with InfluxDB2 but constructing a client right now. By the time I finish this sprint of work, I'll probably drop the InfluxDB2 implementation and come back to it later.

My chief beef right now is that I want one metrics API that can federate to both InfluxDB2 and Prometheus and whatever else and I've not found an existing library to do that. I'm going to end up implementing something for that if I keep InfluxDB2 and it might be... extra and not worthwhile.

I also did some refactoring in this PR while scoping out where in local.go I could add some metrics. That work might be worth its own separate PR...

Fixes #50

colindean commented 2 years ago

@cooperspencer What are your feelings here? What kind of additional counters, gauges, etc. would you find useful?

I'll return to this code this week.

cooperspencer commented 2 years ago

Hi, I will take a look at it tomorrow.

cooperspencer commented 2 years ago

overall it looks good, but it would be nice to have a metric of how long the backups overall took

colindean commented 2 years ago

Added some more stats. I'm pretty happy with what's being output now. I'll build a dashboard in another PR. Let's get this merged before I do any additional refactoring.