coopiteasy / addons

Various modules that extend or improve Odoo Community.
GNU Affero General Public License v3.0
21 stars 17 forks source link

[FIX] prevent global domain variable modification #252

Closed huguesdk closed 2 years ago

huguesdk commented 2 years ago

description

fix mail_activity_filter_internal_user: don't modify the original domain property of the mail.activity.user_id. its initial value is the default empty list defined in the odoo.fields._Relational class, and is thus shared by all fields with a default domain. modifying this variable causes all of these fields to have their domain modified, across all databases.

odoo task

t5760

codecov-commenter commented 2 years ago

Codecov Report

Merging #252 (9122c3d) into 12.0 (0165aaa) will increase coverage by 0.17%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             12.0     #252      +/-   ##
==========================================
+ Coverage   70.11%   70.28%   +0.17%     
==========================================
  Files         115      115              
  Lines        1596     1592       -4     
  Branches      311      309       -2     
==========================================
  Hits         1119     1119              
+ Misses        443      439       -4     
  Partials       34       34              
Impacted Files Coverage Δ
...ivity_filter_internal_user/models/mail_activity.py 55.55% <0.00%> (+17.09%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

carmenbianca commented 2 years ago

/ocabot merge patch

github-grap-bot commented 2 years ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 12.0-ocabot-merge-pr-252-by-carmenbianca-bump-patch, awaiting test results.

github-grap-bot commented 2 years ago

Congratulations, your PR was merged at a39916dc4e633ad89e6918ded31c1014d2e27393. Thanks a lot for contributing to coopiteasy. ❤️