coopiteasy / addons

Various modules that extend or improve Odoo Community.
GNU Affero General Public License v3.0
21 stars 17 forks source link

[FIX] pos_customer_wallet[_*]: Rename foodprint class #263

Closed carmenbianca closed 1 year ago

carmenbianca commented 2 years ago

Signed-off-by: Carmen Bianca Bakker carmen@coopiteasy.be

Description

The class name was wrongly copied from some other place and does not reflect what it's trying to represent.

Odoo task (if applicable)

Reported by @polchampion here

Deploy task: https://gestion.coopiteasy.be/web?debug=1#id=10848&action=475&active_id=264&model=project.task&view_type=form&menu_id=536

Checklist before approval

github-grap-bot commented 2 years ago

Hi @coopiteasy, some modules you are maintaining are being modified, check this out!

codecov-commenter commented 2 years ago

Codecov Report

Merging #263 (88d3710) into 12.0 (e8de43c) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             12.0     #263   +/-   ##
=======================================
  Coverage   69.98%   69.98%           
=======================================
  Files         153      153           
  Lines        2012     2012           
  Branches      366      366           
=======================================
  Hits         1408     1408           
  Misses        566      566           
  Partials       38       38           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

legalsylvain commented 1 year ago

should be rebased and merged ?

legalsylvain commented 1 year ago

Hi https://github.com/coopiteasy, some modules you are maintaining are being modified, check this out!

Hi. I think that the maintainer is not the good one. coop it easy can be set in the author keys, for statistics purpose. But regarding the maintainers, should be "real" people. maintainers give write access to fix / migrate modules. (important if the module moves under OCA umbrella)

carmenbianca commented 1 year ago

Thank you @legalsylvain for the review!

carmenbianca commented 1 year ago

/ocabot merge patch

github-grap-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 12.0-ocabot-merge-pr-263-by-carmenbianca-bump-patch, awaiting test results.

github-grap-bot commented 1 year ago

Congratulations, your PR was merged at f9d4e71a79d93835cec762c4924fc613b9ce8c5e. Thanks a lot for contributing to coopiteasy. ❤️