coopiteasy / addons

Various modules that extend or improve Odoo Community.
GNU Affero General Public License v3.0
21 stars 17 forks source link

[FIX] company_today: Execute every 15 min, remove doall #265

Open carmenbianca opened 1 year ago

carmenbianca commented 1 year ago

Signed-off-by: Carmen Bianca Bakker carmen@coopiteasy.be

Description

Odoo task (if applicable)

Checklist before approval

codecov-commenter commented 1 year ago

Codecov Report

Merging #265 (ec993b2) into 12.0 (0f05213) will increase coverage by 0.09%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             12.0     #265      +/-   ##
==========================================
+ Coverage   70.00%   70.09%   +0.09%     
==========================================
  Files         124      126       +2     
  Lines        1637     1642       +5     
  Branches      316      317       +1     
==========================================
+ Hits         1146     1151       +5     
  Misses        458      458              
  Partials       33       33              
Impacted Files Coverage Δ
partner_no_unique_bank/models/res_partner_bank.py 100.00% <0.00%> (ø)
partner_no_unique_bank/models/__init__.py 100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

carmenbianca commented 1 year ago

for other use cases, once per hour is ok, i think

I am inclined to think not. Nepal has an offset of UTC+5:45.

unless .cron_update_today() first checks whether the value needs to be updated.

I knew I forgot something. I'll do that.

robinkeunen commented 1 year ago

for other use cases, once per hour is ok, i think

I am inclined to think not. Nepal has an offset of UTC+5:45.

Also the town of Eucla (UTC+08:45) at the border of West Australia (UTC+08:00) and Southern Australia (UTC+09:45). Apparently, it was more convenient to relay telegraph messages. Maintained for retro-compatibility I guess...

robinkeunen commented 8 months ago

@carmenbianca should we merge or close ?