[16.0] [MIG] email_template_config

[victor-champonnois]

https://gestion.coopiteasy.be/web#id=10959&action=475&active_id=492&model=project.task&view_type=form&menu_id=

[codecov-commenter]

Codecov Report

Merging #301 (0a897a4) into 16.0 (e110213) will decrease coverage by 0.36%. The diff coverage is 87.50%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             16.0     #301      +/-   ##
==========================================
- Coverage   97.73%   97.37%   -0.36%     
==========================================
  Files          12       15       +3     
  Lines         221      229       +8     
  Branches       30       30              
==========================================
+ Hits          216      223       +7     
- Misses          1        2       +1     
  Partials        4        4              

Files Changed	Coverage Δ
email_template_config/models/mail_template.py	83.33% <83.33%> (ø)
email_template_config/__init__.py	100.00% <100.00%> (ø)
email_template_config/models/__init__.py	100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[victor-champonnois]

• why does the cooperator modules depend on this module fo function properly while not declaring the dependency ?

It does not strictly depend on it. It might be required for implementation for which we don't want or can't send email to cooperators

• force_send's default value is False (that is, put in the email queue). Therefore it should not block the mail unless we `send_mail(id, force_send=True)

and we indeed do in cooperator/models/account_invoice, line 197 : email_template.sudo().send_mail(self.id, True). I don't know why the force send is set in this line, though.

• it should be named mail_template_force_send or the like

Yes good idea

[huguesdk]

note: while in version 12 and 14, there are indeed 2 mail messages sent with force_send=True, this argument has been removed from all send_mail() calls in version 16.

[robinkeunen]

@huguesdk indeed but a force_send=True is still implicitely called by action_reset_password :

https://github.com/OCA/OCB/blob/b9fd7c5ac938fb0fc265abc7a4d202c3fd090b7b/addons/auth_signup/models/res_users.py#L224

[robinkeunen]

Discuté sur la tâche : ne pas porter 💩