search

coopiteasy / addons

Various modules that extend or improve Odoo Community.
GNU Affero General Public License v3.0
21 stars 17 forks source link

[16.0] [MIG] sale_order_volume #305

Closed victor-champonnois closed 4 months ago

victor-champonnois commented 1 year ago

task : https://gestion.coopiteasy.be/web#id=10931&action=475&active_id=492&model=project.task&view_type=form&menu_id=

victor-champonnois commented 1 year ago

Test fails in CI, but not in my local setup.

carmenbianca commented 1 year ago

/ocabot rebase

github-grap-bot commented 1 year ago

Congratulations, PR rebased to 16.0.

carmenbianca commented 1 year ago

pushed a WIP commit to the branch. there's still work to be done.

carmenbianca commented 1 year ago

Patched up, I reckon.

The test was wrong. It expected 1 pallet for the service category where 0 should have been expected.

Cleaned up the module a whole lot.

victor-champonnois commented 1 year ago

@carmenbianca thanks much !

codecov-commenter commented 1 year ago

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 94.29%. Comparing base (110387a) to head (6429b71).

Files Patch % Lines
sale_order_volume/models/sale_order.py 90.47% 1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 16.0 #305 +/- ## ========================================== + Coverage 94.17% 94.29% +0.11% ========================================== Files 34 41 +7 Lines 584 631 +47 Branches 56 63 +7 ========================================== + Hits 550 595 +45 - Misses 27 28 +1 - Partials 7 8 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

victor-champonnois commented 8 months ago

@carmenbianca can you approve this PR ?

victor-champonnois commented 7 months ago

@polchampion Yes I realised the last changes were not deployed. I also corrected the sale order report. It should be OK now

polchampion commented 7 months ago

@polchampion Yes I realised the last changes were not deployed. I also corrected the sale order report. It should be OK now

LGTM

victor-champonnois commented 6 months ago

@carmenbianca could you re-review this PR ?

polchampion commented 4 months ago

@carmenbianca ping

victor-champonnois commented 4 months ago

/ocabot merge nobump

github-grap-bot commented 4 months ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-305-by-victor-champonnois-bump-nobump, awaiting test results.

github-grap-bot commented 4 months ago

Congratulations, your PR was merged at 7e2ad595c0877fbea199e35f4499d9051e4af01d. Thanks a lot for contributing to coopiteasy. ❤️