coopiteasy / addons

Various modules that extend or improve Odoo Community.
GNU Affero General Public License v3.0
21 stars 17 forks source link

[16.0][MIG] pos_customer_wallet_partner_is_user #307

Open carmenbianca opened 1 year ago

carmenbianca commented 1 year ago

Description

Depends on #300

Odoo task (if applicable)

https://gestion.coopiteasy.be/web#id=10798&action=475&active_id=492&model=project.task&view_type=form&menu_id=536

Checklist before approval

polchampion commented 8 months ago

@carmenbianca I updated the above review just now

carmenbianca commented 8 months ago

Looks like the field isn't computed based on wallet credit or usage; also it can be changed manually.

It was always a manual field. This has not changed in the migration.

forbids certain accounting operations from happening if the partner is not a customer wallet user --> what operations ?

It forbids the user from using the wallet payment method in the POS. An error shows up. However, I may delete this code because…

Hide the customer wallet payment method if the selected partner is not a user. --> NOK

I just added this. This makes the above code redundant.

Hide the customer wallet balance if the selected partner is not a user. don't know since the balance is never displayed yet

A few notes:


I updated the code on the test server.