search

coopiteasy / addons

Various modules that extend or improve Odoo Community.
GNU Affero General Public License v3.0
21 stars 17 forks source link

[16.0][MIG] l10n_be_national_number #318

Open victor-champonnois opened 6 months ago

victor-champonnois commented 6 months ago

l10n_be_national_number was implemented in v14 and published on https://github.com/OCA/l10n-belgium. In v16, there is the module https://github.com/OCA/l10n-belgium/tree/16.0/l10n_be_partner_identification that does the same thing with more functionalities.

We need to migrate the data. The module l10n_be_national_number is moved here, and contain a migration script and a dependency to l10n_be_partner_identification.

internal task https://gestion.coopiteasy.be/web?debug=1#id=12259&action=479&model=project.task&view_type=form&menu_id=536

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.17%. Comparing base (e99dc87) to head (39ec13a).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 16.0 #318 +/- ## ======================================= Coverage 94.17% 94.17% ======================================= Files 34 34 Lines 584 584 Branches 56 56 ======================================= Hits 550 550 Misses 27 27 Partials 7 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

victor-champonnois commented 6 months ago

@huguesdk thanks for the review, PR fixed!

victor-champonnois commented 6 months ago

@huguesdk fixed !

victor-champonnois commented 5 months ago

/ocabot merge nobump

github-grap-bot commented 5 months ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-318-by-victor-champonnois-bump-nobump, awaiting test results.

github-grap-bot commented 5 months ago

@victor-champonnois your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-318-by-victor-champonnois-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

victor-champonnois commented 5 months ago

/ocabot merge nobump

github-grap-bot commented 5 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-318-by-victor-champonnois-bump-nobump, awaiting test results.

github-grap-bot commented 5 months ago

@victor-champonnois your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-318-by-victor-champonnois-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

github-grap-bot commented 4 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖