coopiteasy / vertical-cooperative

Odoo modules for managing cooperative shares and membership.
GNU Affero General Public License v3.0
38 stars 26 forks source link

[REF] cooperator: improve unit tests #393

Closed robinkeunen closed 2 years ago

robinkeunen commented 2 years ago

Set up account test data in python rather than relying on module data. accounting data needs to be created even if created in module data because when launching tests, accounting data will be deleted when odoo loads a test chart of account. cf load_for_current_company in chart_template.py in account module

Also remove manual creation of the chart of account and remy on the test one.

Setup is made in a mixin than can be imported in other cooperator modules.

Description

Odoo task (if applicable)

Checklist before approval

codecov-commenter commented 2 years ago

Codecov Report

Merging #393 (d076ba1) into 12.0 (70cf9a6) will decrease coverage by 3.86%. The diff coverage is 96.19%.

@@            Coverage Diff             @@
##             12.0     #393      +/-   ##
==========================================
- Coverage   61.27%   57.41%   -3.87%     
==========================================
  Files          98       98              
  Lines        3688     3670      -18     
  Branches      548      549       +1     
==========================================
- Hits         2260     2107     -153     
- Misses       1356     1505     +149     
+ Partials       72       58      -14     
Impacted Files Coverage Δ
cooperator/models/subscription_request.py 72.51% <ø> (ø)
cooperator/tests/__init__.py 100.00% <ø> (ø)
cooperator/tests/cooperator_test_mixin.py 93.33% <93.33%> (ø)
cooperator/tests/test_cooperator.py 98.07% <97.33%> (-1.93%) :arrow_down:
easy_my_coop_loan/tests/test_emc_loan.py 8.88% <0.00%> (-91.12%) :arrow_down:
easy_my_coop_loan/models/loan_issue_line.py 29.80% <0.00%> (-49.01%) :arrow_down:
easy_my_coop_loan/models/loan_issue.py 47.95% <0.00%> (-12.25%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

robinkeunen commented 2 years ago

For easy_my_coop_loan, this is probably due to broken stuff, I'll have a look. For the 2% of cooperator, I have no idea.

robinkeunen commented 2 years ago

closed in favor of https://github.com/OCA/cooperative/pull/7

robinkeunen commented 2 years ago

closed in favor of https://github.com/OCA/cooperative/pull/7