search

coopnorge / github-workflow-release-drafter

0 stars 0 forks source link

feat: allow ignoring of major changes if path matches pattern #34

Closed arunpoudel closed 11 months ago

arunpoudel commented 11 months ago

Context:

We have had issues in our internal projects where release-drafter-go was being used to automatically tag go projects, where the release-drafter tagged the PR as major changes because it was trying to introduce breaking changes to a path, */v1beta1.*

We have agreed on that specific project, that breaking changes are allowed for v1beta1 beta however not allowed for v1 APIs.

We needed a mechanism in release-drafter-go that allowed us to ignore major changes to path matching a pattern, and simply tag it as a minor bump.

misund commented 11 months ago

Why not bump the major instead?

misund commented 11 months ago

I think I misunderstood at first.

Would I be correct to assume that the intention is to allow for breaking changes within a beta branch, so that a feature can be changed in a breaking way while doing betas? But it would still not be breaking on the v1 branch if introduced there?

If allowing this, would it still detect changes that in fact would break the v1 branch if introduced?

arunpoudel commented 11 months ago

@misund This is to allow changes in v1beta to be breaking, while still keeping the the logic for rest to be the same.

Let's assume the scenario where we are working on only v1beta1 of a greenfield project. We will want to allow there to be breaking changes to the APIs in such case. However, once the api has been promoted to v1 ie stable, we want any breaking changes to be tagged as major in the PR.