search

coopnorge / provider-github

Apache License 2.0
27 stars 13 forks source link

add github_emu_group_mapping resource #51

Closed tomasmota closed 7 months ago

tomasmota commented 7 months ago

Adds github_emu_group_mapping

How has this code been tested

I have no way of adding a test case, since that would require external_groups to be added to the provider too, which would be cumbersome due to it being a data source which just gives a list of things. The way I will use this is by having the terraform provider use the external_groups data source and then fetch that data into this resource.

I have nonetheless tested it's usage manually with our groups and it works.

AtzeDeVries commented 7 months ago

@tomasmota Thanks for the contribution.

Added one comment. Also can you resync since #50 just got merged and now generates a conflict.

tomasmota commented 7 months ago

I've moved it now

AtzeDeVries commented 7 months ago

config/provider.go is not linted correctly.

tomasmota commented 7 months ago

sorry, should be good now

AtzeDeVries commented 7 months ago

@tomasmota thanks

AtzeDeVries commented 7 months ago

https://marketplace.upbound.io/providers/coopnorge/provider-github/v0.7.0