search

coopnorge / provider-github

Apache License 2.0
23 stars 11 forks source link

fix reference to team in emugroupmapping #52

Closed tomasmota closed 4 months ago

tomasmota commented 4 months ago

The reference to the team did not specify that the slug must be used instead of the ID, so teamSlugSelector and teamSlugRef did not work. I have fixed it and tested both of them.

Also fixed the placing of commends in external_name.go, which got messed up with the earlier rebase.

AtzeDeVries commented 4 months ago

@tomasmota thanks! i see i did not properly check the previous PR is see. I just assumed the CI to be ok in this case.

tomasmota commented 4 months ago

yeah, let me know if I should do anything else before you can merge

AtzeDeVries commented 4 months ago

mm just trying to find out detect-noop is true (and thus not running any ci).

AtzeDeVries commented 4 months ago

@tomasmota https://marketplace.upbound.io/providers/coopnorge/provider-github/v0.7.1