Open max-si-m opened 5 months ago
Hello, I've been recently integrated with your gem, and that is a wonderful piece of art. Helped me a lot, thank you. You did a great job.
I found some places that might be improved or changed according to my understanding:
Some models missed the dependent and inverse_of for associations.
No generator for models (needed for sharding and fixing associations).
No way to attach API routes without a dashboard, when the dashboard isn't required or forbidden.
Shouldn't the line 27 be moved to the 32? Is there a reason to generate stale pkpass? https://github.com/coorasse/passkit/blob/c7ef36a7859e95dfca6f93db271ffafee4bca2fa/app/controllers/passkit/api/v1/passes_controller.rb#L27-L32
I was curious what is the reason for having multiple passes per one generator? I mean when we have the same class for pass and generator. I've patched that to use find_or_create_by! but I'm wondering, maybe I'm missing something? Wouldn't it create a lot of redundant records?https://github.com/coorasse/passkit/blob/3522c16680a35f1d75780c9ab4dc76c9dd21bd43/lib/passkit/factory.rb#L5-L7
find_or_create_by!
Maybe those findings would be helpful. If they are helpful somehow, I can help with some of them if needed.
Hello, I've been recently integrated with your gem, and that is a wonderful piece of art. Helped me a lot, thank you. You did a great job.
I found some places that might be improved or changed according to my understanding:
Some models missed the dependent and inverse_of for associations.
No generator for models (needed for sharding and fixing associations).
No way to attach API routes without a dashboard, when the dashboard isn't required or forbidden.
Shouldn't the line 27 be moved to the 32? Is there a reason to generate stale pkpass? https://github.com/coorasse/passkit/blob/c7ef36a7859e95dfca6f93db271ffafee4bca2fa/app/controllers/passkit/api/v1/passes_controller.rb#L27-L32
I was curious what is the reason for having multiple passes per one generator? I mean when we have the same class for pass and generator. I've patched that to use
find_or_create_by!but I'm wondering, maybe I'm missing something? Wouldn't it create a lot of redundant records?https://github.com/coorasse/passkit/blob/3522c16680a35f1d75780c9ab4dc76c9dd21bd43/lib/passkit/factory.rb#L5-L7Maybe those findings would be helpful. If they are helpful somehow, I can help with some of them if needed.