Question: Why are we using uint8 instead of enum for role and permissions?

coordinape / coordinape-protocol

🏆 Coordinape contracts

MIT License

32 stars 12 forks source link

Question: Why are we using uint8 instead of enum for role and permissions? #9

Closed Niraj-Kamdar closed 2 years ago

crabsinger commented 2 years ago

@Niraj-Kamdar Can you link to the line you're seeing this in?

Niraj-Kamdar commented 2 years ago

https://github.com/coordinape/coordinape-protocol/blob/feat/V1/contracts/circles/CoordinapeRole.sol https://github.com/coordinape/coordinape-protocol/blob/feat/V1/contracts/circles/Coordinape.sol

KeatonKirk commented 2 years ago

Hey @crabsinger! If y'all want to update those libraries flagged by @Niraj-Kamdar I'd be happy to make that change and submit a PR, just let me know!

levity commented 2 years ago

hey @KeatonKirk, you can feel free to do it, just know that right now we're focused on getting the vaults contracts shipped, and the circles are lower-priority, so they may still change a lot.