search

coosamatt / javapns

javapns
0 stars 0 forks source link

SSLConnectionHelper: different keystores for inputstream/path #21

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The two constructors of SSLConnectionHelper (where the keystore is given as
path and inputstream respectively) call 

this.keyStore = KeyStore.getInstance(keystoreType, "BC");

and 

this.keyStore = KeyStore.getInstance(keystoreType);

which makes a difference depending on what providers are installed.

Original issue reported on code.google.com by hsifdr...@gmail.com on 28 May 2010 at 2:28

GoogleCodeExporter commented 8 years ago 
So the inputstream call needs to be updated to include "BC" as an arguement?

Original comment by idbill.p...@gmail.com on 3 Jun 2010 at 3:52

GoogleCodeExporter commented 8 years ago 
I think you have it inverted. It is the constructor:
[public SSLConnectionHelper(String appleHost, int applePort, InputStream 
keyStoreInputStream, String keyStorePass, String keystoreType)]
that specifies the "BC", and that one does not work.

you can remove the "BC" 
[this.keyStore = KeyStore.getInstance(keystoreType);]
and the constructor will work just fine.

Original comment by dev.serg...@gmail.com on 16 Aug 2010 at 2:31

GoogleCodeExporter commented 8 years ago 
The change has been committed.

Original comment by idbill.p...@gmail.com on 16 Aug 2010 at 4:51