search

coosamatt / javapns

javapns
0 stars 0 forks source link

PushNotificationManager a bit restrictive #7

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
PushNotificationManager requires the keystore to be a file to be accessed by 
FileInputStream.  This 
limits how the certificate is bundled with the project.

It will be nice to relax it to be accept InputStream as well.  Attached is my 
patch.

Also, I recommend that you make SSLConnectionHelper be a packaged scope.  While 
it is helpful as 
an independent class to get SSLConnection, no other class in the project can 
take an instance of it 
as a parameter.  Currently it is used as a holder to keystore types.

Original issue reported on code.google.com by msaeed43 on 28 Aug 2009 at 8:24

Attachments:

GoogleCodeExporter commented 8 years ago 
Thanks for your patches, i added it in the new version of javapns.

Original comment by maxime.p...@gmail.com on 30 Nov 2009 at 9:52