coova / coova-chilli

CoovaChilli is an open-source software access controller for captive portal hotspots.
Other
516 stars 258 forks source link

FIX: Invalid JSON in chilliJSON.reply #136

Closed daniel-sullivan closed 8 years ago

daniel-sullivan commented 8 years ago

Was having an issue that in the nasid field in the JSON response to the refresh action wasn't formatted correctly.

Eg: chillJSON.reply({version: "1.0", clientState: 0, nasid: nas01" ......

It looks like there was an issue in redir.c not adding the additional quote. I've attached the changed file (as redir.txt). Could someone with the time to set up a repo and do a pull request please put this through for me? I'd like to share this fix but just don't have time. I have a captive portal to get done...

Daniel Sullivan

Contributions to CoovaChilli

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the modified BSD license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same modified BSD license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Additionally, I certify that:

(e) The contribution can be licensed under the modified BSD license, as shown below, and the GPL license, in LICENSE file, even in case of files that are currently licensed under other terms.

(f) I understand that my contribution is licensed under the modified BSD license contained in this file, but that the CoovaChilli combined work remains licensed under the GPL license contained in the LICENSE file.

To indicate your acceptance of these terms, please add the following line to each contribution you make to the project:

Signed-by: Daniel Sullivan <daniel.sullivan@reticulum.it redir.txt