coova / coova-chilli

CoovaChilli is an open-source software access controller for captive portal hotspots.
Other
518 stars 260 forks source link

AC_FUNC_MALLOC and AC_FUNC_REALLOC checks introduced build problems #153

Closed ynezz closed 8 years ago

ynezz commented 8 years ago

Hi, the commit https://github.com/coova/coova-chilli/commit/39e29a98c091f4b5d5c1cfc0174ca8086b80df2f introduced a lot of new checks which breaks the builds for me, mainly while doing cross compilations:

/opt/devel/coova-chilli.git/src/ms_chap.c:121: undefined reference to `rpl_malloc'
/opt/devel/coova-chilli.git/bstring/bstrlib.c:1693: undefined reference to `rpl_realloc'

More info here http://wiki.buici.com/xwiki/bin/view/Programing+C+and+C%2B%2B/Autoconf+and+RPL_MALLOC and https://www.gnu.org/software/autoconf/manual/autoconf-2.60/html_node/Particular-Functions.html#AC_FUNC_MALLOC.

If it was working for coova so far (this malloc/realloc problems are usually seen on Win32 platform) I don't see any reason to introduce more bloat :) To fix it properly, you'll have to provide correct implementation for malloc/realloc etc. I doubt it's worth the time.

Thanks!