coova / coova-chilli

CoovaChilli is an open-source software access controller for captive portal hotspots.
Other
516 stars 258 forks source link

Fix issue #151 #160

Closed gbaligh closed 8 years ago

ynezz commented 8 years ago

@gbaligh Please can you try to improve your commit messages? I'm trying to address this in #162, until it's discussed, improved and merged, can you please read this git commit message guidelines? :-)

The better commit would be:

Fix compile warnings in JSON tokenizer

I'm getting following warnings on my Ubuntu XY with compiler version X.Y.Z:

json_tokener.c: In function 'json_tokener_do_parse':
json_tokener.c:241:6: warning: pointer targets in passing argument 2 of 'printbuf_memappend' differ in signedness [-Wpointer-sign]
      printbuf_memappend(this->pb, utf_out, 1);
      ^

Fixes #151

Signed-off-by: Baligh GUESMI <your@email.com>
gbaligh commented 8 years ago

Ok, I'll do it in a new branch.