coova / coova-chilli

CoovaChilli is an open-source software access controller for captive portal hotspots.
Other
518 stars 260 forks source link

Travis #165

Closed sevan closed 8 years ago

ynezz commented 8 years ago

@sevan Please can you read our updated CONTRIBUTING.md guide and try to comply with it?

sevan commented 8 years ago

Being a member of project implies working under the compliance of the terms, doesn't it? (happy to add the signing off bit). Regarding the duplication of information, a matter of taste?

ynezz commented 8 years ago

@sevan

Being a member of project implies working under the compliance of the terms, doesn't it?

IANAL, but if this is the case, you should probably ask @wlanmac and modify CONTRIBUTING.md accordingly to make it clear.

Regarding the duplication of information, a matter of taste?

It's a well-established convention to not do this in projects managed by VCS as this information is already contained in the VCS metadata and it could be read back easily once it's needed using git log --stat for example.

Well, to make it clear and explicit, we should probably add link to How to Write a Git Commit Message (or just take out some small summary) to our CONTRIBUTING.md.

sevan commented 8 years ago

how about less bureaucracy?

ynezz commented 8 years ago

@sevan If you look at #90 it's clear, that we need some standards or rules, otherwise its going to be a unmaintanable mess. Does it means more bureaucracy, maybe, but it's being done for a better quality of code etc.

sevan commented 8 years ago

Ticket #90 is about coding standards. I would like to see your contributions in that discussion rather than spending the energy on nit picking. Bureaucracy is not going to impact the quality of the code in the actual commit.