Logging API for coova-chilli

coova / coova-chilli

CoovaChilli is an open-source software access controller for captive portal hotspots.

Other

518 stars 260 forks source link

Logging API for coova-chilli #170

Closed gbaligh closed 8 years ago

gbaligh commented 8 years ago

This is my proposal for Logging interface:

Default logging
Logging per module
Environment variable to change level per module

This pull is for review

sevan commented 8 years ago

Hi, Just a heads up about the license in your cod, have you considered the licensing terms in the contributors agreement? (double checking in case)

gbaligh commented 8 years ago

Ok, I'll use this one. What do you think about the interface, technically speaking ?

sevan commented 8 years ago

I'll try and take a look next week (I'm pre-occupied with something else at the moment). Perhaps, for the sake of discussion, why is this needed & what does it improve over the use of syslog(3)

gbaligh commented 8 years ago

syslog(3) will be the base of all logging. Advantages:

Debug one module and not all chilli modules
Avoid wrapping any call to syslog() by _options.debug
One central module for logging manager, if we need to change something for logging, it will be easier.