search

coova / coova-chilli

CoovaChilli is an open-source software access controller for captive portal hotspots.
Other
518 stars 260 forks source link

add override of username if received in an Access-Accept packet #206

Closed CristiCimpianu closed 8 years ago

CristiCimpianu commented 8 years ago

according to https://tools.ietf.org/html/rfc2865, section 5.1, the User-Name attribute may be sent in an Access-Accept packet the client should use the given username for the accounting session that follows.

I came across this in the context of a scenario where a wifi user is moving from one access point to another and I need to avoid re-authentication. So I configured coova to do macauth and the radius server will search for an open session for the client MAC and return the real authenticated username in the Access-Accept packet. The client will start a new accounting session, but it will still be tracked with the real username and thus, the account restrictions will apply.

jobezic commented 8 years ago

Are configure.ac and src/Makefile.am changes related to this issue?

CristiCimpianu commented 8 years ago

@pinkra No, just the first commit is related to this issue. The second commit seems to have been added to the same pull request because this one was already open and I pushed to the same branch.

jobezic commented 8 years ago

Can you clean it?

CristiCimpianu commented 8 years ago

@pinkra done. I reset my master branch by one commit.