coova / coova-chilli

CoovaChilli is an open-source software access controller for captive portal hotspots.
Other
518 stars 260 forks source link

Sh bash #309

Closed sevan closed 7 years ago

sevan commented 7 years ago

Another /bin/sh -> /usr/bin/env bash

nzamps commented 7 years ago

What about systems without bash ? - this doesn't seem to work.

Maybe use env $SHELL

sevan commented 7 years ago

out of curiosity, what shell are you likely to find on your systems? I'm testing with primarily pdksh here but looking at alchemist as well.

nzamps commented 7 years ago

Our smaller systems use busybox so SHELL=/bin/ash

sevan commented 7 years ago

That would create further hurdles with having to deal with login shell / executing shell. I reverted these commits, apologies if I caused any inconvenience.