search

coova / coova-chilli

CoovaChilli is an open-source software access controller for captive portal hotspots.
Other
518 stars 260 forks source link

Small fixes to Debian packaging #333

Closed valholl closed 7 years ago

valholl commented 7 years ago

While trying to build a deb I've found it had a number of issues including missing dependencies and a wrong version number,

This pull request fixes those and adds a few other trivial changes that fix some warnings.

It has been tested under both stretch (current testing) and jessie (current stable).

Please let me know if you need me to change anything

sevan commented 7 years ago

Hi, Thanks for the submission! Where does the python & python-gtk dependency come from?

valholl commented 7 years ago

On 2017-01-05 at 16:27:40 -0800, Sevan Janiyan wrote:

Where does the python & python-gtk dependency come from?

from conf/CoovaChilliLib.py

maybe it should be a Recommends instead of a Depend? (if so, I'll update the PR)

-- Elena ``of Valhalla''

jobezic commented 7 years ago

yes, it should be optional..

sevan commented 7 years ago

@valholl if the python & gtk dependencies aren't installed, what functionality do you lose in coova?

valholl commented 7 years ago

@sevan Actually, I don't know: I was trying to build the deb package to install coova and try it out, and most of the contents of the PR came from the suggestions of some QA tools usually used in debian to check the debs (and I tried to select only the ones that are usually quite safe; there were others that may or may not be good suggestions that I skipped)

valholl commented 7 years ago

I updated the PR to turn that dependency in a Suggests, since if I understand correctly those python files aren't really needed?