search

coova / coova-chilli

CoovaChilli is an open-source software access controller for captive portal hotspots.
Other
518 stars 260 forks source link

chilli_query logout <MAC> breaks macallowed feature #385

Open irongomme opened 7 years ago

irongomme commented 7 years ago

After testing, I've noticed that for a given mac address (ie: 00-11-22-33-44-55), declared in macallowed setting :

if I use the cli command : 

$ chilli_query logout 00-11-22-33-44-55

Then, automatic login for this mac address don't work anymore. I have to restart coovachilli to make it work again ! And I think it should be able to reconnect automatically after a logout, doesn't it ?

gbaligh commented 7 years ago

Hi,

Try to use chilli_query dhcp-release 00-11-22-33-44-55.

The problem is that when using logout it'll release only session and not the host connection. Next time when the host try to connect, it'll be assigned to a known connection and no MAC check will be done according. Maybe we can add check over logout command so that it do not accept MAC address as argument, and do accept IP address only.

irongomme commented 7 years ago

For me, advantage of logout is to disonnect a device from radius server, but mac addresses in macallowed, with the macallowlocal, are not connected from radius server. So I think in that case, those addresses should not be impacted by logout command to prevent this kind of issue, because the only way to make it work again is to restart chilli.