search

coova / coova-chilli

CoovaChilli is an open-source software access controller for captive portal hotspots.
Other
516 stars 258 forks source link

Miniportal Refactor #66

Closed jobezic closed 8 years ago

jobezic commented 9 years ago

I think we can refactor the miniportal using html+js.. with the help of @mpangrazzi! What do you think @wlanmac @sevan ?

mpangrazzi commented 9 years ago

:+1:

IMHO (and as you said), it would be great to deprecate haserl, and use directly Pepper for logon (CHAP/PAP) on a modern HTML5 UI, with all JS code in a Browserify bundle.

muratbeser commented 9 years ago

Pepper is a great tool but I think we need something minimal, with less dependency, I'm using AngularJS in my project so Pepper requires others stuff too.

wlanmac commented 9 years ago

I like the angular js idea! On Jul 6, 2015 5:31 AM, "Murat BEŞER" notifications@github.com wrote:

Pepper is a great tool but I think we need something minimal, with less dependency, I'm using AngularJS in my project so Pepper requires others stuff too.

— Reply to this email directly or view it on GitHub https://github.com/coova/coova-chilli/issues/66#issuecomment-118840229.

mpangrazzi commented 9 years ago

:-1:

I'm sorry, but I don't like it.

Since miniportal is a simple app, IMHO it's better to stay away from JS frameworks and write clean, modular code with vanilla JS and tools like Browserify.

This way, users who don't know AngularJS (or whatever) could understand better the code flow and build up their own personal solution with ease.

@muratbeser Pepper has only three dependencies and no browser-compat issues. Also, you can easily integrate Pepper in any AngularJS apps using Browserify.

Spomky commented 9 years ago

I agree with @mpangrazzi Please keep in mind that coovachilli is also installed on routeurs with small memory and should be as light as possible.This kind of project is great, but adds a lot of dependencies. It may be part of a third party package IMHO.

muratbeser commented 9 years ago

I'm Agree with @Spomky but I think we need pure javascript with OOP some people like me can customize it. Also we can make two examples with examples they can understand the progress.

@mpangrazzi yes I saw it but issue all about minimal dependency requirement approach also more dependency means more BC.

@wlanmac David, I'm just using it on my project, I'm not offering it. But yes Angular is great library. We can write some service for it but I think it has to be sync not aSync so its another project or branch I think.

jobezic commented 9 years ago

@mpangrazzi Will it take long?

sevan commented 9 years ago

Happy to go with what you guys think is best here.

mpangrazzi commented 9 years ago

@pinkra I'm sorry but I haven't had much free time slots in the last month. Also, I still have to add PAP support to Pepper. BTW, it's not a long task, I hope to have more free time in the next month!

I'll keep you updated.

jobezic commented 9 years ago

Don't worry, just to be updated ;)