search

coova / coova-chilli

CoovaChilli is an open-source software access controller for captive portal hotspots.
Other
516 stars 258 forks source link

generate more unique session id #80

Closed gareth41 closed 8 years ago

gareth41 commented 9 years ago

I'm testing chilli in a backpackers hostel here in Auckland, getting around 100 logins every day. Occasionally though we get duplicate session id's appear in the mysql radacct table, this seems to happen at-least once every 2 - 3 days. Does anyone know the chilli source file used to generate the session id?

nzamps commented 9 years ago

Take a look at set_sessionid in chilli.c and mainclock_rt - do you have time set with ntp ?

Also in Auckland! :)

On 26/07/2015, at 6:38 pm, gareth41 notifications@github.com wrote:

I'm testing chilli in a backpackers hostel here in Auckland, getting around 100 logins every day. Occasionally though we get duplicate session id's appear in the mysql radacct table, this seems to happen at-least once every 2 - 3 days. Does anyone know the chilli source file used to generate the session id?

— Reply to this email directly or view it on GitHub https://github.com/coova/coova-chilli/issues/80.

gufmar commented 9 years ago

according to http://freeradius.org/radiusd/man/rlm_acct_unique.txt it's not uncommon that some NAS does not provide really unique Acct-session-id . So this rlm_acct_unique module should create an unique Acct-Unique-Session-Id Looking at our 3,4 million accounting records recorded in the past 5 days from around 500 NAS-devices we see several hundred duplicate Acct-session-id's coming from the same NAS device. Thanks to the mentioned module the Acct-unique-session-id's are "much more" unique. But not really 100% ... not even for the same NAS. As all our hotspot locations have unique DHCP-ranges we added the Framed-IP-Address to the table index to solve this problem.