search

copiesofcopies / youtube-transcription

Apache License 2.0
72 stars 8 forks source link

Modify existing manifest file #4

Closed waldoj closed 11 years ago

waldoj commented 11 years ago

Perhaps I'm not the ideal use case for this, but I think it might be better to modify the provided manifest than to create a new one. Given that the modification is non-destructive, and given that the manifest was surely created expressly for the purpose of running through this tool, I don't think that there's any harm in modifying it. The current arrangement requires a bit more thinking and file management than is necessary. (Perhaps -o could be an optional flag, for those who prefer not to modify their master manifest?)

copiesofcopies commented 11 years ago

I think you're right about this. I considered both and ultimately fell back to creating a new manifest basically to prevent data loss should the original get corrupted, but that shouldn't actually be a problem and there are better ways to account for it if it is. I like the optional -o idea.

copiesofcopies commented 11 years ago

Fixed in commit e4ae6d913a3fa66b7b7d2d6bd78939301fd94ca1