search

copiousfreetime / stickler

a tool to organize and maintain an internal gem distribution server
MIT License
143 stars 29 forks source link

Mirror errors when no gem-version supplied #42

Closed MikaelSmith closed 9 years ago

MikaelSmith commented 9 years ago

Using ruby 2.1.5p273 (2014-11-13 revision 48405) [x86_64-darwin14.0] and Stickler version 2.4.1 on Mac OS X 10.10.1:

$ stickler mirror deep_merge --server http://my.mirror
/Users/michaelsmith/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/stickler-2.4.1/lib/stickler/client/mirror.rb:37:in `block in parse'
/Users/michaelsmith/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/stickler-2.4.1/lib/stickler/client.rb:33:in `block in parse'
/Users/michaelsmith/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/trollop-2.0/lib/trollop.rb:740:in `with_standard_exception_handling'
/Users/michaelsmith/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/stickler-2.4.1/lib/stickler/client.rb:31:in `parse'
/Users/michaelsmith/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/stickler-2.4.1/lib/stickler/client/mirror.rb:31:in `parse'
/Users/michaelsmith/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/stickler-2.4.1/lib/stickler/client/mirror.rb:80:in `run'
/Users/michaelsmith/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/stickler-2.4.1/bin/stickler:55:in `<top (required)>'
/Users/michaelsmith/.rbenv/versions/2.1.5/bin/stickler:23:in `load'
/Users/michaelsmith/.rbenv/versions/2.1.5/bin/stickler:23:in `<main>'
ERROR -> undefined local variable or method `lock' for #<Stickler::Client::Mirror:0x007f9022491588>

This appears to be because the lock variable doesn't exist, and should be gemfile_lock.

MikaelSmith commented 9 years ago

PR #43 addresses this.

copiousfreetime commented 9 years ago

Thanks, I appreciate it.