search

copper-leaf / clog

Zero-config Kotlin multiplatform logging utility
https://copper-leaf.github.io/clog/
BSD 3-Clause "New" or "Revised" License
18 stars 3 forks source link

Support macOS #5

Open ghost opened 3 years ago

ghost commented 3 years ago

In addition to the iOS target I would also need logging support on macOS (macosX64 target).

cjbrooks12 commented 3 years ago

This would be a very welcome addition! I've never done anything with macOS native targets so I'm not quite sure what all would be required to get this enabled, but I would gladly accept a PR to get it set up.

This project is set up already to use HMPP, so is there a sourceSet that would be able to service both iOS and native macOS targets, or would it just need a new one specifically for macOS?

ghost commented 3 years ago

Looking at the Kermit lib they managed to define a single darwinMain sourceSet for both, but in my project I just added macosX64("macos") { } below iOS { } and copied iosMain to macosMain. That was all that I needed to do. Actually I tried to prepare a PR for you with that, but I cancelled that due to tooling issues - Android Studio won't compile your project for me and it was hard enough to get mine compiled. All that beta stuff. ;)

I think it should be easy for you to add the macOS target. Implementation can be the same.

cjbrooks12 commented 3 years ago

Cool, yeah I was hoping it would be pretty easy for that. Do you mind pushing that branch up somewhere so I can take a look? It should be pretty easy for me to get that integrated and released (probably sometime this weekend)

ghost commented 3 years ago

Change the build.gradle.kts like this: https://github.com/AshStefanOltmann/clog/commit/46ccbd0e6a5615240ad13a0555f36e06d5af8e44

And copy iosMain to macosMain

That should be all that's needed.