copycats-plus / copycats

All the copycats you've ever wanted, combined into a single mod!
Other
30 stars 8 forks source link

[Bug] Schematicannon tries to place air when trying to place multistate copycat blocks #147

Closed Tera458 closed 2 months ago

Tera458 commented 3 months ago

Describe the bug When making a schematic containing copycat blocks allowing multistate and putting it in a schematicannon, a majority of those copycat blocks will cause the schematicannon to say it requires air. I only managed to pinpoint it to bytes and half layers, wether they are full with the same materials, made out of different materials, same material of different orientations, or not full, as well as double slabs made out the same materials, made out of different materials but one has a different orientation, or same materials but different orientations.

To Reproduce Steps to reproduce the behavior:

  1. Place copycat blocks which allow multistates
  2. Create a schematic with them inside
  3. Place the schematic in a schematicannon and provide the needed materials, make sure skip missing blocks isnt selected
  4. Schematicannon will be stuck trying to place air
  5. If missing blocks are skipped, most multistates copycat blocks will not have been placed

Expected behavior The schematicannon shouldnt interpret those blocks as air.

Screenshots Screenshot_2667 2024-08-17_15 43 34

Desktop (please complete the following information):

Additional context My only guess of the cause would be some kind of character limit for the blockstates. Creative mode direct placement works flawlessly, and material checklists list the materials accurately

hlysine commented 3 months ago

I haven't investigated it in detail but my guess is that the getRequiredItems method is buggy and lists air as a requirement for unfilled parts of a multi-state.

mkern1200 commented 3 months ago

Our server is currently experiencing this issue as well (same Minecraft/Fabric mod versions).

hlysine commented 2 months ago

This has been fixed in e1035289b719998ff0e833c03357d1ce2ac4e51c