copycats-plus / copycats

All the copycats you've ever wanted, combined into a single mod!
Other
24 stars 8 forks source link

[Bug] Lagspike due to com.copycatsplus.copycats.compat.Mods.rl() #173

Open Bomb787 opened 2 days ago

Bomb787 commented 2 days ago

I've been getting some weird FPS drops while playing my personal pack, and Spark seems to say it's coming from Copycats+. Did a little bit of testing and it seems like it's correct.

To Reproduce

  1. Install Copycats+
  2. Open a world
  3. Load some chunks (more apparent if moving quickly, speed 255 on a superflat world).
  4. FPS drops much more than without Copycats+ installed.

Expected behavior The game should not be losing that much FPS.

Screenshots Screenshot 2024-11-03 015127

Desktop:

Additional context Strangely, the issue is even more pronounced if WorldEdit is installed.

hlysine commented 1 day ago

Thanks a lot for the profiling. This should be an easy fix by caching the resource location.