copygirl / AdvHealthOptions

Minecraft mod which allows customizing health regen and more
MIT License
6 stars 0 forks source link

Server Crash on Player Respawn #1

Closed cdempsey closed 10 years ago

cdempsey commented 10 years ago

Good morning!

While testing out a private modpack that contains AHO the server crashed when I died in lava (I sure "love" Lucky Blocks!) on respawn. I'm running Forge Mod Loader version 7.10.24.1187 for Minecraft 1.7.10 and AHO 1.4.0.6. It's also running the stock config options for AHO.

Here's the stacktrace from the server: [https://paste.ee/p/ilD6O]

copygirl commented 10 years ago

I should've known. For now, if respawn.food is set to 20 it may not crash.

cdempsey commented 10 years ago

I'll give a shot and let ya' know.

On Sunday, July 20, 2014, copygirl notifications@github.com wrote:

I should've known.

For now, if respawn.food is set to 20 it may not crash.

— Reply to this email directly or view it on GitHub https://github.com/copygirl/AdvHealthOptions/issues/1#issuecomment-49558013 .

cdempsey commented 10 years ago

I attempted to test this by changing the respawn food config option to 20 on the server. The issue was then that when I connected with the client the default AdvHealthOptions.cfg is apparently re-written out. This sets the value back to 16.

I tested this by changing the server's value for respawn food to 20, letting it sit for 5 minutes, and then checked the respawn food config value which was 20 as expected. I then connected with a client and did nothing else (I didn't even move). When I did that I looked in the server's AdvHealthOptions.cfg and the respawn food value was 16. I also checked the client's AdvHealthOptions.cfg and its respawn food was 16 too (I'd set that to 20 on the client too).

cdempsey commented 10 years ago

Nevermind. The server's version of AdvHealthOptions.cfg being replaced when the server starts up.

copygirl commented 10 years ago

I hope this works, fix should be in 1.4.1.7.

cdempsey commented 10 years ago

Nice! Thanks!

On Jul 21, 2014, at 6:38 PM, copygirl notifications@github.com wrote:

Closed #1 via ff3ba0d.

— Reply to this email directly or view it on GitHub.

cdempsey commented 10 years ago

I'll give it a go when it's out.

On Jul 21, 2014, at 6:45 PM, copygirl notifications@github.com wrote:

I hope this works, fix should be in 1.4.1.7.

— Reply to this email directly or view it on GitHub.

copygirl commented 10 years ago

The release is out already. Have at it!

cdempsey commented 10 years ago

Fixed the issue for me. I wiped out the custom config files and let 1.4.1.7 just generate the default ones. On death, the server didn't die and the player had 8 chicken legs (which I believe is food=16) on respawn.

Nice job!