search

copygirl / BetterStorage

A Minecraft mod aimed at offering more storage options.
http://copy.mcft.net/mc/BetterStorage/
MIT License
57 stars 33 forks source link

NoClassDefFoundError IconRegister with Crafting Station #183

Closed oitsjustjose closed 10 years ago

oitsjustjose commented 10 years ago

After playing on my modserver with BetterStorage and using the Crafting Station as my primary means of crafting, I've found two bugs. First one comes with a crash report (from my server, not the client), which can be found here: http://pastebin.com/d1c5V4Tu

edit: Moved the second bug to #187.

oitsjustjose commented 10 years ago

The first of two bugs is evidently now preventing my server from even starting, which I find odd, but here's another log for you, it's just a bit different.... http://pastebin.com/fEJZm6NY

copygirl commented 10 years ago

Thanks! The NoClassDefFoundError sounds like I'm missing @SideOnly(Side.CLIENT) somewhere, so that's an easy fix. And I'll look into why the crafting station eats keys (or all container items?) too.

copygirl commented 10 years ago

NoClassDefFoundError is actually caused by BiomesOPlenty, because they're missing a @SideOnly(Side.CLIENT) on their registerIcons method for the Scythe, may also be the case for other items in BoP (and indeed it looks like that's the case) and other mods.

Why doesn't it crash sooner? Java. That's why. I'm checking to see if onCreated is overridden in the items crafted through the crafting station - using reflection. If it is overridden, it can't be crafted automatically, only when a player does it.

oitsjustjose commented 10 years ago

All I was doing was creating an IC2 Bronze Axe, and the server crashed immediately when using the Crafting Station. Not sure what the problem is, but it might be on your side? Nonetheless, have another log! http://pastebin.com/MMQvWWhZ

Thanks for working on it copygirl :smile:

copygirl commented 10 years ago

Yup, same thing, gotta tell the IC2 guys too.