copygirl / BetterStorage

A Minecraft mod aimed at offering more storage options.
http://copy.mcft.net/mc/BetterStorage/
MIT License
57 stars 33 forks source link

Fix recipe sorter, ore dictionary support #306

Closed Adaptivity closed 8 years ago

Adaptivity commented 9 years ago

Chests and crafting tabels were registered to have better compatibility with ganymedes01's WoodStuff mod. Also, closes #290

@copygirl Can you pull two my PRs and make a new release?

copygirl commented 9 years ago

I don't have anything set up to even build it, and I've given up responsibility. I'll leave it up to @Victorious3 and friends. Unless you want to go ahead and maintain it, feel free to release your fork to the public.

Adaptivity commented 9 years ago

Maybe @Victorious3 can merge this too and make a new release then? I would appreciate this.

Adaptivity commented 9 years ago

Oh, this should be used for reinforced chests... but I don't really know how to change chest recipes. Maybe you can leave this here, so maybe someone will add support for actual recipes later?

copygirl commented 9 years ago

I guess what should be done is checking the ore dictionary for whether the entry exists, and if not, just use chests instead. Might not work if mods add ore dictionary entries after BS registers their recipes though.

Adaptivity commented 9 years ago

No reason to do checking. Better to register it, I've added support for a few mods (Buildcraft and Ender IO, as I remember) and it's working great.