copygirl / WearableBackpacks

Minecraft mod which adds beautiful, balanced backpacks
MIT License
61 stars 35 forks source link

[Sponge / FTB Utilities] Unequipping Backpack in protected area makes backpack disappear #41

Open FabioZumbi12 opened 7 years ago

FabioZumbi12 commented 7 years ago

Hi, I using WearableBackpacks on my Sponge server and when i try to put my backpack on a protect area not owned by me (using Sponge plugin) the backpack disapears, but only if the backpack is on my back.

No problems if i try to place from my hand. I cant place and didnt disapear, like expected ;)

copygirl commented 7 years ago

If you go out of the protected area and try to place the backpack (even if you don't see it), does it place it? Or is it gone forever?

copygirl commented 7 years ago

Note to self: At ProxyCommon.java:181, replace with PlayerInteractionManager.processRightClick?

FabioZumbi12 commented 7 years ago

Yeah, out of protection works fine from hand and from our back. I do not know much about MODs, on truth i am the dev of that protection plugin.

Maybe if you use the same event as when we try to get on the floor while the bag is in our hand.

copygirl commented 7 years ago

Let me clarify the question, since it's important: If you placed your backpack in a protected area and it disappears, is this only a visual glitch, or can you later place it down outside a protected area and everything is fine?

FabioZumbi12 commented 7 years ago

(sorry, i am portuguese and may i have not expressed me corrrectly)

Nono, It disapear(and i cant get back, not a visual glitch) from my back and from my hand, and from ground, but only if the Backpack is on my back. If the BP is on my hand theres no bugs.

copygirl commented 7 years ago

@JBYoshi informed me that this might be partially an issue in Sponge: SpongePowered/SpongeCommon#1417

Since this is Sponge this is not highest priority. I will eventually come back to this and fix placing / accessing in restricted areas proper. For example, Adventure mode is also broken with backpacks afaik.

FabioZumbi12 commented 7 years ago

Oh, thanks for fast reply <3

Seems Sponge team already is working to fix this ^^ Waiting a fix.

JBYoshi commented 7 years ago

It should be fixed on the latest Sponge builds.

copygirl commented 6 years ago

@FabioZumbi12 Is the issue fixed for you now?

nephatrine commented 5 years ago

This is also an issue with FTB Utilities claimed/protected chunks. Accidentally shift-clicked on someone else's land and backpack popped out of existence entirely with all my stuff. Would love an op-only command that could restore someone's last-worn backpack or something.

copygirl commented 5 years ago

Which is kind of annoying because you'd expect at least FTB to hook into the Vanilla functions and make them return false upon testing whether a player has the permission / ability to place a block somewhere.

Is the backpack truly gone or does it just visually disappear from your back? I can't imagine it would allow the block to be placed only to silently remove it after. So, does relogging fix it?

nephatrine commented 5 years ago

It seemed to be truly gone. Couldn't open with keybind, wasn't visually on back, couldn't shift-place in my own land anymore, etc. I didn't try relogging because I ended up just rolling back to the last backup I had and manually adding the ability for all ranks to edit backpacks on claims to "resolve" the issue. Just added this to the FTBU ranks file for all ranks:

ftbutilities.claims.block.edit.wearablebackpacks.backpack: true

That's still not ideal since it's not a default setting and allows unintended theft from players who want to use backpacks as chests or decoration but works otherwise.

willvex commented 5 years ago

This same bug happens with redprotect protected areas.