copyliu / furigana_inserter

Automatically exported from code.google.com/p/itadaki
Other
1 stars 0 forks source link

Hiragana alphabet not working in 2.5 #25

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hi, I just upgraded to 2.5 today and noticed it wasn't inserting any ruby for 
me. After fidgeting around a bit I noticed it was only hiragana alphabet not 
being inserted.

I think the issue is probably a missing

var HiraganaSimple = Simple;

in ruby.js somewhere around line 46
(at least that's how I fixed it locally)

Original issue reported on code.google.com by tutal...@gmail.com on 12 Oct 2012 at 4:23

GoogleCodeExporter commented 8 years ago
Addendum: I guess I only ran into this because 
extensions.furiganainserter.tokenize is user-set to true.
Not sure how this happened, maybe from an early version?
I didn't find an actual menu entry that seemed to toggle this value in the 
options dialogue.

Original comment by tutal...@gmail.com on 12 Oct 2012 at 4:44

GoogleCodeExporter commented 8 years ago
Thanks for the bug report. Indeed your solution is right and fixes the problem. 
Thanks. I will fix it in 2.6.

It only happens when extensions.furiganainserter.tokenize is set to false, 
which is not the default. I removed this option from the options dialog and 
forgot to test it.

Original comment by zorkz...@hotmail.com on 12 Oct 2012 at 5:00