coq-community / coq-ext-lib

A library of Coq definitions, theorems, and tactics. [maintainers=@gmalecha,@liyishuai]
https://coq-community.org/coq-ext-lib/
BSD 2-Clause "Simplified" License
129 stars 46 forks source link

Adapt w.r.t. coq/coq#16004. #127

Closed ppedrot closed 2 years ago

liyishuai commented 2 years ago

Is there a way to make it backward compatible?

ppedrot commented 2 years ago

Up to which version do you want it to be compatible? In theory the current patch should be compatible up to 8.14, I don't know why the CI failed. With a few tweaks it can be made compatible up to 8.11.

liyishuai commented 2 years ago

All dependants of this library (per OPAM) currently develop on Coq >= 8.11, so it's fine to drop support to older Coq versions.

ppedrot commented 2 years ago

@liyishuai this should be backwards compatible up to 8.11 now.

ppedrot commented 2 years ago

@liyishuai ping

liyishuai commented 2 years ago

Cherry-picking 27022dbb6486f2ed802f292cededd001cbac0851 should fix the CI.