fix: interpolated scripts couldn't contain single-quotes

coq-community / docker-coq-action

GitHub Action using Docker-Coq [maintainers=@erikmd,@Zimmi48]

MIT License

12 stars 4 forks source link

fix: interpolated scripts couldn't contain single-quotes #41

Closed erikmd closed 3 years ago

erikmd commented 3 years ago

Kind: bugfix
Close #40 (Cc @gares FYI)

Summary:

Improve the moperl function (no need for the previous bash quoting hack)

@Zimmi48 I only did manual unit tests for now :) so I'll merge this and make a point release very soon, after I've done an e2e test.

erikmd commented 3 years ago

Sorry @gares for not merging this sooner 😅 - as the underlying function was a critical part of the parsing for the customizable fields of the action, I really wanted to back-up this change with more tests and ideally some automated tests.

Now, with #60, docker-coq-action also has some dedicated CI, so I was able to directly add a regression test for the bug #40 you had reported, and merge the fix.

Planning to do a point release (docker-coq-action v1.2.4) in a short while.